bharathv commented on pull request #1601: URL: https://github.com/apache/hbase/pull/1601#issuecomment-623162755
>The comment in code is incorrect, even for BlockingRpcConnection, the callMethod is still asynchronous... > But for the protobuf stub, it also has the ability to do asynchronous call(BlockingInterface vs. Interface, newBlockingStub vs. newStub), so wrapping on the stub can also solve the hedged read problem, and this is exactly what we have done for implementing the read replicas feature. Ah that makes sense. I missed this part, thanks for pointing it out. I was under the impression that the BlockingRpcClient was always defaulted to a blockingRpcChannel instead of async RpcChannel(). In that case, I think it is much easier to wrap multiple RpcChannels and support both connection types. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
