wchevreuil commented on a change in pull request #1633:
URL: https://github.com/apache/hbase/pull/1633#discussion_r419282676



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java
##########
@@ -376,7 +376,7 @@ public void loadHFileQueue(AsyncClusterConnection conn, 
TableName tableName,
    * atomically.
    * @return empty list if success, list of items to retry on recoverable 
failure
    */
-  private CompletableFuture<Collection<LoadQueueItem>> tryAtomicRegionLoad(
+  protected CompletableFuture<Collection<LoadQueueItem>> tryAtomicRegionLoad(

Review comment:
       Nit: Since method is now _protected_, let's add @param tags on javadoc 
description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to