gjacoby126 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420370515
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -80,4 +93,19 @@ public KeepDeletedCells getKeepDeletedCells() {
return keepDeletedCells != null ? keepDeletedCells :
scanInfo.getKeepDeletedCells();
}
+ @Override
+ public int getMinVersions() {
+ return minVersions != null ? minVersions : scanInfo.getMinVersions();
+ }
+
+ @Override
+ public void setMinVersions(int minVersions) {
+ this.minVersions = minVersions;
+ }
+
+ @Override
+ public Scan getScan() {
+ return scan;
Review comment:
Scan is mostly mutable, I think. That's a good point -- the clone in the
constructor will prevent changes from executing, but a caller could still mess
up the state for future callers. I'll clone in the getter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
