saintstack commented on a change in pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#discussion_r420552955
##########
File path: dev-support/create-release/do-release.sh
##########
@@ -66,26 +82,34 @@ function should_build {
fi
}
-if should_build "tag" && [ $SKIP_TAG = 0 ]; then
+if should_build "tag" && [ "$SKIP_TAG" = 0 ]; then
run_silent "Creating release tag $RELEASE_TAG..." "tag.log" \
- "$SELF/release-tag.sh"
- echo "It may take some time for the tag to be synchronized to github."
- echo "Press enter when you've verified that the new tag ($RELEASE_TAG) is
available."
- read
+ "$SELF/release-build.sh" tag
+ if is_dry_run; then
+ export TAG_SAME_DRY_RUN="true";
+ else
+ echo "It may take some time for the tag to be synchronized to github."
+ echo "Press enter when you've verified that the new tag ($RELEASE_TAG) is
available."
+ read -r
+ fi
Review comment:
No hurry. Nice-to-have. Can come later too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
