huaxiangsun commented on a change in pull request #1629:
URL: https://github.com/apache/hbase/pull/1629#discussion_r420563488
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java
##########
@@ -78,6 +78,13 @@ protected Flow executeFromState(MasterProcedureEnv env,
GCMergedRegionsState sta
switch (state) {
case GC_MERGED_REGIONS_PREPARE:
// Nothing to do to prepare.
Review comment:
Hi @nyl3532016, can you put your above comment "If
GCMultipleMergedRegionsProcedure processing is slower than the CatalogJanitor's
scan interval, it will end resubmitting GCMultipleMergedRegionsProcedure for
the same region, we can skip duplicate GCMultipleMergedRegionsProcedure" to the
code above? It will help other developers's code reading easier. After that,
you can merge, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
