gjacoby126 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r422657613
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -80,4 +97,23 @@ public KeepDeletedCells getKeepDeletedCells() {
return keepDeletedCells != null ? keepDeletedCells :
scanInfo.getKeepDeletedCells();
}
+ @Override
+ public int getMinVersions() {
+ return minVersions != null ? minVersions : scanInfo.getMinVersions();
+ }
+
+ @Override
+ public void setMinVersions(int minVersions) {
+ this.minVersions = minVersions;
+ }
+
+ @Override
+ public Scan getScan() {
+ try {
+ return new Scan(scan);
Review comment:
@anoopsjohn In the original draft it was only cloned in the
constructor. @apurtell pointed out that that meant that one coproc override
could call getScan(), call a setter on the Scan, and that a subsequent override
would see the modified Scan, so he asked me to fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
