[
https://issues.apache.org/jira/browse/HBASE-24262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yaojingyi updated HBASE-24262:
------------------------------
Description:
If we start major compaction on a big table first,
then we modified compaction limit configuration and execute 'update_config'
command,
it will not effective immediately.
The compaction which is running is still use the old Controller object.
The higher.bound,lower.bound,offPeakHours is still the old value.
I think we can make the modification effective immediately.
There is 2 points about it:
1.keep there is always only one PressureAwareCompactionThroughputController
object in RS.
2.add a updateConfig method in Controller.
when we use 'update_config' command to update compact pressure conf , it just
change the value of higher.bound,lower.bound,offPeakHours ,instead of create a
new Controller
was:
If we start major compaction on a big table first,
then we modified compaction limit configuration and execute 'update_config'
command,
it will not effective immediately.
The compaction which is running is still use the old Controller object.
The higher.bound,lower.bound,offPeakHours is still the old value.
I think we can make the modification effective immediately.
There is 3 points about it:
1.keep there is always only one PressureAwareCompactionThroughputController
object in RS.
2.add a updateConfig method in Controller.
3.when we use 'update_config' command to update compact pressure conf , it just
change the value of higher.bound,lower.bound,offPeakHours ,instead of create a
new Controller
> Improvement update_config for PressureAwareCompactionThroughputController
> -------------------------------------------------------------------------
>
> Key: HBASE-24262
> URL: https://issues.apache.org/jira/browse/HBASE-24262
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Affects Versions: master
> Reporter: yaojingyi
> Assignee: yaojingyi
> Priority: Major
> Attachments: HBASE-24262.master.001.patch,
> HBASE-24262.master.002.patch
>
>
> If we start major compaction on a big table first,
> then we modified compaction limit configuration and execute 'update_config'
> command,
> it will not effective immediately.
> The compaction which is running is still use the old Controller object.
> The higher.bound,lower.bound,offPeakHours is still the old value.
>
> I think we can make the modification effective immediately.
> There is 2 points about it:
> 1.keep there is always only one PressureAwareCompactionThroughputController
> object in RS.
> 2.add a updateConfig method in Controller.
> when we use 'update_config' command to update compact pressure conf , it just
> change the value of higher.bound,lower.bound,offPeakHours ,instead of create
> a new Controller
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
