[ 
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260269#comment-13260269
 ] 

Lars Hofhansl commented on HBASE-5848:
--------------------------------------

@Ram: That is probably overkill, means another loop over the splitKeys before 
they are sorted. As long as it fails on the client (even with an NPE) and does 
not cause the master to abort it's fine I think.

If you like to add the extra check now, that fine too.

+1 in either case. Going to bed now, feel free to commit :)

                
> Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to 
> abort
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-5848
>                 URL: https://issues.apache.org/jira/browse/HBASE-5848
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Hofhansl
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5848.patch, HBASE-5848.patch
>
>
> A coworker of mine just had this scenario. It does not make sense the 
> EMPTY_START_ROW as splitKey (since the region with the empty start key is 
> implicit), but it should not cause the HMaster to abort.
> The abort happens because it tries to bulk assign the same region twice and 
> then runs into race conditions with ZK.
> The same would (presumably) happen when two identical split keys are passed, 
> but the client blocks that. The simplest solution here is to also block 
> passed null or EMPTY_START_ROW as split key by the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to