[ https://issues.apache.org/jira/browse/HBASE-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260288#comment-13260288 ]
Hadoop QA commented on HBASE-5672: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521633/HBASE-5672v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1624//console This message is automatically generated. > TestLruBlockCache#testBackgroundEvictionThread fails occasionally > ----------------------------------------------------------------- > > Key: HBASE-5672 > URL: https://issues.apache.org/jira/browse/HBASE-5672 > Project: HBase > Issue Type: Bug > Reporter: chunhui shen > Assignee: chunhui shen > Attachments: HBASE-5672.patch, HBASE-5672v2.patch > > > We find TestLruBlockCache#testBackgroundEvictionThread fails occasionally. > I think it's a problem of the test case. > Because runEviction() only do evictionThread.evict(): > {code} > public void evict() { > synchronized(this) { > this.notify(); // FindBugs NN_NAKED_NOTIFY > } > } > {code} > However when we call evictionThread.evict(), the evictionThread may haven't > been in run() in the TestLruBlockCache#testBackgroundEvictionThread. > If we run the test many times, we could find failture easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira