[
https://issues.apache.org/jira/browse/HBASE-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260345#comment-13260345
]
Hadoop QA commented on HBASE-5863:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523940/HBASE-5863.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1625//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1625//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1625//console
This message is automatically generated.
> Improve the graceful_stop.sh CLI help (especially about reloads)
> ----------------------------------------------------------------
>
> Key: HBASE-5863
> URL: https://issues.apache.org/jira/browse/HBASE-5863
> Project: HBase
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: HBASE-5863.patch
>
>
> Right now, graceful_stop.sh prints:
> {code}
> Usage: graceful_stop.sh [--config <conf-dir>] [--restart] [--reload]
> [--thrift] [--rest] <hostname>
> thrift If we should stop/start thrift before/after the hbase stop/start
> rest If we should stop/start rest before/after the hbase stop/start
> restart If we should restart after graceful stop
> reload Move offloaded regions back on to the stopped server
> debug Move offloaded regions back on to the stopped server
> hostname Hostname of server we are to stop
> {code}
> This does not help us specify that "reload" is actually a sub/additive-option
> to "restart".
> Also, the "debug" line seems to still have an old copy/paste mistake.
> I've updated these two in the patch here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
