[ 
https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107493#comment-17107493
 ] 

Josh Elser commented on HBASE-24347:
------------------------------------

{quote}IIRC I’ve reviewed a patch from Josh to address this problem by using -D 
instead of -P in the script? We haven’t applied the patch to all branches?
{quote}

bq. Personally I would prefer a single maintenance point for the personality 
over the ability to test branch-specific personality changes in a PR.

Yes, we made this change only in master. Do PR's pull precommit logic from the 
branch the PR is targeting? If that's what they do, we can just prepare 
cherry-picks to address it.

(Specifically avoiding the discussion around where PR's should pull their logic 
from)

> Hadoop2&Hadoop3 profiles are both active when pre-commit PR builds run
> ----------------------------------------------------------------------
>
>                 Key: HBASE-24347
>                 URL: https://issues.apache.org/jira/browse/HBASE-24347
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Michael Stack
>            Priority: Major
>
> We need the magic done in the parent out in our precommit builds too. See how 
> https://github.com/apache/hbase/pull/1664 fails in hbase-rest w/ complaint 
> about jersey; this is a symptom of double hadoop2+hadoop3 profile activation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to