busbey commented on a change in pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#discussion_r426321582
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -102,12 +102,26 @@ if [ -d "$WORKDIR/output" ]; then
fi
fi
+if [ -f "${WORKDIR}/gpg-proxy.ssh.pid" ] || \
+ [ -f "${WORKDIR}/gpg-proxy.cid" ] || \
+ [ -f "${WORKDIR}/release.cid" ]; then
+ read -r -p "container/pid files from prior run exists. Overwrite and
continue? [y/n] " ANSWER
+ if [ "$ANSWER" != "y" ]; then
+ error "Exiting."
+ fi
+fi
+
cd "$WORKDIR"
rm -rf "$WORKDIR/output"
+rm -rf "${WORKDIR}/gpg-proxy.ssh.pid" "${WORKDIR}/gpg-proxy.cid"
"${WORKDIR}/release.cid"
Review comment:
so the clean up function should take care of them, but something can go
wrong such that they don't get handled.
since docker will fail loudly if the passed container id file path exists,
this ensures we have a smooth path back to running again even if something goes
wrong.
also the latest version of the WIP has an option to purposefully leave those
files in place at the end of execution in case someone needs to debug what the
containers are doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
