francisliu commented on a change in pull request #1418:
URL: https://github.com/apache/hbase/pull/1418#discussion_r427851802
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
##########
@@ -752,9 +785,17 @@ public static HRegionInfo convert(final
HBaseProtos.RegionInfo proto) {
// RegionInfo into HRegionInfo which is what is wanted here.
HRegionInfo hri;
if (ri.isMetaRegion()) {
- hri = ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID ?
+ //TODO francis room for streamlining this logic
+ hri = ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID &&
ri.getRegionId() == 1
Review comment:
Yeah since we had it for meta. Which should have it for catalog as a
whole too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
