HorizonNet commented on a change in pull request #1731:
URL: https://github.com/apache/hbase/pull/1731#discussion_r428200525
##########
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
##########
@@ -304,6 +305,56 @@ public void testWithMockedMapReduceWithNoStartRowStopRow()
throws Exception {
}
}
+ @Test
+ public void testScanLimit() throws Exception {
+ setupCluster();
Review comment:
Does it make sense to move this one to a test initializer method? I see
it used in several tests in here.
##########
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
##########
@@ -304,6 +305,56 @@ public void testWithMockedMapReduceWithNoStartRowStopRow()
throws Exception {
}
}
+ @Test
+ public void testScanLimit() throws Exception {
+ setupCluster();
+ final TableName tableName = TableName.valueOf(name.getMethodName());
+ final String snapshotName = tableName + "Snapshot";
+ Table table = null;
+ try {
+
UTIL.getConfiguration().setInt(SNAPSHOT_INPUTFORMAT_ROW_LIMIT_PER_INPUTSPLIT,
10);
+ if (UTIL.getAdmin().tableExists(tableName)) {
+ UTIL.deleteTable(tableName);
+ }
+
+ UTIL.createTable(tableName, FAMILIES, new byte[][] { bbb, yyy });
+
+ Admin admin = UTIL.getAdmin();
+
+ int regionNum = admin.getRegions(tableName).size();
+ // put some stuff in the table
+ table = UTIL.getConnection().getTable(tableName);
+ UTIL.loadTable(table, FAMILIES);
+
+ Path rootDir = CommonFSUtils.getRootDir(UTIL.getConfiguration());
+ FileSystem fs = rootDir.getFileSystem(UTIL.getConfiguration());
+
+ SnapshotTestingUtils.createSnapshotAndValidate(admin, tableName,
Arrays.asList(FAMILIES),
+ null, snapshotName, rootDir, fs, true);
+
+ Job job = new Job(UTIL.getConfiguration());
+ Path tmpTableDir = UTIL.getDataTestDirOnTestFS(snapshotName);
+ Scan scan = new Scan();
+ TableMapReduceUtil.addDependencyJarsForClasses(job.getConfiguration(),
+ TestTableSnapshotInputFormat.class);
+
+ TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName, scan,
+ RowCounter.RowCounterMapper.class, NullWritable.class,
NullWritable.class, job, true,
+ tmpTableDir);
+ Assert.assertTrue(job.waitForCompletion(true));
+ Assert.assertEquals(10 * regionNum,
+
job.getCounters().findCounter(RowCounter.RowCounterMapper.Counters.ROWS).getValue());
+ } finally {
+ if (table != null) {
+ table.close();
+ }
+
UTIL.getConfiguration().unset(SNAPSHOT_INPUTFORMAT_ROW_LIMIT_PER_INPUTSPLIT);
+ UTIL.getAdmin().deleteSnapshot(snapshotName);
+ UTIL.deleteTable(tableName);
+ tearDownCluster();
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
