Apache9 commented on a change in pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#discussion_r428464957
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2444,8 +2451,16 @@ public FlushResultImpl flushcache(boolean
forceFlushAllStores, boolean writeFlus
}
try {
- Collection<HStore> specificStoresToFlush =
+ Collection<HStore> specificStoresToFlush = null;
+ if (!forceFlushAllStores && families != null) {
+ specificStoresToFlush = stores.entrySet().stream()
+ .filter(e -> families.contains(Bytes.toString(e.getKey())))
Review comment:
In the WAL interface, we all use byte[] as family name, so I prefer we
also use byte[] here. You could use TreeSet with BytesComparator to hold byte[].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
