joshelser commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r428961966
##########
File path: NOTICE
##########
@@ -0,0 +1,15 @@
+Apache HBase
+Copyright 2019 The Apache Software Foundation
Review comment:
2020 now :)
##########
File path: cmake/DownloadProject.CMakeLists.autogen.in
##########
@@ -0,0 +1,19 @@
+# Distributed under the OSI-approved MIT License. See accompanying
+# file LICENSE or https://github.com/Crascit/DownloadProject for details.
Review comment:
Weird that Crascit doesn't have the normal MIT license header. I guess
we leave it rather than put the real MIT license text.
##########
File path: src/hbase/test-util/mini-cluster.cc
##########
@@ -34,7 +34,7 @@ JNIEnv *MiniCluster::CreateVM(JavaVM **jvm) {
char *classpath = getenv("CLASSPATH");
std::string clspath;
if (classpath == NULL || strstr(classpath, "-tests.jar") == NULL) {
- std::string
clsPathFilePath("../../../hbase-build-configuration/target/cached_classpath.txt");
+ std::string clsPathFilePath("../target/cached_classpath.txt");
Review comment:
I reckon this doesn't work after removing the native client out of the
"main" HBase java repository.
##########
File path: cmake/patches/zookeeper.3.4.14.buf
##########
@@ -0,0 +1,3767 @@
+/**
Review comment:
What is this patching?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
