apurtell commented on a change in pull request #1749:
URL: https://github.com/apache/hbase/pull/1749#discussion_r429453178
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
##########
@@ -183,18 +176,21 @@ public void run() {
if (LOG.isInfoEnabled()) LOG.info("Chore: " + getName() + " was
stopped");
} else {
try {
+ // TODO: Histogram metrics per chore name.
+ // For now, just measure and log if DEBUG level logging is enabled.
+ long start = 0;
+ if (LOG.isDebugEnabled()) {
+ start = System.nanoTime();
+ }
if (!initialChoreComplete) {
initialChoreComplete = initialChore();
} else {
- timeMeasurement.measure(() -> {
chore();
- return null;
- });
- if (LOG.isInfoEnabled() && (System.nanoTime() - lastLog >
FIVE_MINUTES_IN_NANOS)) {
Review comment:
Not opposed to the idea at all, but it's going to depend on the chore,
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
