VicoWu commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-632964520
> @jojochuang > This issue is found by our cluster incident. > But my current commit still has some problem which need to be resolved before finally adopted: > > In this PR, I cache the token between RS and NameNode instead of always applying for a new one every time processing a file, so the token should be confirmed that it is not expired every time before we use it; > So I think I need to add a check logic to verify its expiration time , if it is already or going to be expired, I will have to apply for a new one and overwrite the cache; @jojochuang Would you please have a review for my above fix planning? If you think it is ok, I will add the token expiration process logic to avoid the cached token expiration and apply for new token before it is expired; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
