[ 
https://issues.apache.org/jira/browse/HBASE-24422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115572#comment-17115572
 ] 

Bharath Vissapragada commented on HBASE-24422:
----------------------------------------------

[~stack] Yes, I verified that. So the least common ancestor commit for both the 
client implementations (master vs git repo) is at [this commit 
|https://github.com/apache/hbase-native-client/commit/89dda63e04b3ced210cee71b1773c17d9f6d9768]

I checked out this commit from the git repo implementation and diff'ed the 
contents in both the directories.

HBase master repo:
{noformat}
git log --oneline
c303f9d329 (origin/master, origin/HEAD) HBASE-24408 Introduce a general 'local 
region' to store data on master (#1753)
a9fefd7f53 HBASE-24297 release scripts should be able to use a custom git repo
8ff8e70edf HBASE-24296 install yetus as a part of building the rm docker image.
{noformat}
hbase-native-client git repo
{noformat}
89dda63 (HEAD -> div) HBASE-14087 Ensure correct ASF headers for docs/code
2e8bfb8 HBASE-10302 Fix rat check issues in hbase-native-client.
920676a HBASE-9977 Define C interface of HBase Client Asynchronous APIs
{noformat}

diff

{noformat}
diff -q hbase/hbase-native-client/ hbase-native-client/
Common subdirectories: hbase/hbase-native-client/bin and hbase-native-client/bin
Common subdirectories: hbase/hbase-native-client/cmake_modules and 
hbase-native-client/cmake_modules
Only in hbase-native-client/: .git
Only in hbase-native-client/: NOTICE
Common subdirectories: hbase/hbase-native-client/src and hbase-native-client/src
{noformat}

So hbase-native-client git repo is strictly a superset of the contents in 
hbase/hbase-native-client.

> Remove hbase-native-client code from the master branch
> ------------------------------------------------------
>
>                 Key: HBASE-24422
>                 URL: https://issues.apache.org/jira/browse/HBASE-24422
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: master
>            Reporter: Bharath Vissapragada
>            Assignee: Bharath Vissapragada
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1
>
>
> Per recent discussions in the slack channel, there is not much value
> in having this code in the master branch. This code has it's dedicated
> git repo at https://github.com/apache/hbase-native-client.
> It was already removed from branch-1 (HBASE-19419) and branch-2
> (HBASE-19176)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to