[ 
https://issues.apache.org/jira/browse/HBASE-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5862:
---------------------------------

    Attachment: HBASE-5862-2.patch

HRegionServer.dynamicMetrics registers it's self with the Hadoop Metrics.  From 
then on the metrics are polled by a thread outside of hbase.

We clear everything in order to clear schema metrics and metrics about cf's.  
It would be time consuming to iterate through all metrics and see if they are 
for column families that are still being served.  Since the metrics are reset 
by jmx every time it comes through removing them is not great but saves a lot 
of string comparisons and ensures that all edge cases are covered.

I added the bool to make sure that initializing is only tried once.

Changed the or to a && since only clearing half doesn't get the job done so 
better not not try if one field was not accessible.
                
> After Region Close remove the Operation Metrics.
> ------------------------------------------------
>
>                 Key: HBASE-5862
>                 URL: https://issues.apache.org/jira/browse/HBASE-5862
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Minor
>         Attachments: HBASE-5862-0.patch, HBASE-5862-1.patch, 
> HBASE-5862-2.patch
>
>
> If a region is closed then Hadoop metrics shouldn't still be reporting about 
> that region.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to