Joseph295 commented on a change in pull request #1783:
URL: https://github.com/apache/hbase/pull/1783#discussion_r430933648
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -955,19 +964,24 @@ private void bulkLoadHFile(HStoreFile sf) throws
IOException {
if (!result.isEmpty()) {
// initialize the thread pool for closing store files in parallel.
ThreadPoolExecutor storeFileCloserThreadPool = this.region
- .getStoreFileOpenAndCloseThreadPool("StoreFileCloser-"
- + this.region.getRegionInfo().getEncodedName() + "-" +
this.getColumnFamilyName());
-
+ .getStoreFileOpenAndCloseThreadPool();
+ String executingThreadNamePrefix = "StoreFileCloser-"
+ + this.region.getRegionInfo().getEncodedName() + "-" +
this.getColumnFamilyName();
+ AtomicInteger threadId = new AtomicInteger(0);
// close each store file in parallel
CompletionService<Void> completionService =
new ExecutorCompletionService<>(storeFileCloserThreadPool);
for (HStoreFile f : result) {
completionService.submit(new Callable<Void>() {
@Override
public Void call() throws IOException {
+ Thread t = Thread.currentThread();
Review comment:
> All these looks bit hacky
Changing the thread name is not necessary, but it will be useful when jstack
the process, we will know something in detail.Yeah, it's bit hacky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
