[ https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117921#comment-17117921 ]
Andrew Kyle Purtell commented on HBASE-24446: --------------------------------------------- Agreed. We shouldn’t have direct use of System#getCurrentMillis anywhere in our code except in the EnvironmentEdgeManager facade. > Use EnvironmentEdgeManager to compute clock skew in Master > ---------------------------------------------------------- > > Key: HBASE-24446 > URL: https://issues.apache.org/jira/browse/HBASE-24446 > Project: HBase > Issue Type: Bug > Affects Versions: 1.6.0 > Reporter: Sandeep Guggilam > Assignee: Sandeep Guggilam > Priority: Minor > Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0 > > > There are few cases where the Master is not able to complete the > initialization as it waiting for the region server to report to it. The > region server actually reported to the master but the master rejected the > request because of clock skew issue though both of them are on same JVM > The Region server uses EnvironmentEdgeManager.currentTime to report the > current time and HMaster uses System.currentTimeMillis() to get the current > time for computation against the reported time by RS. We should also just > use EnvironmentEdgeManager even in Master as we are expected not to use > System.currentTime directly and instead go through EnvironmentEdgeManager > -- This message was sent by Atlassian Jira (v8.3.4#803005)