joshelser commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r432186426
########## File path: cmake/DownloadFolly.cmake ########## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +## Download facebook's folly library. +## SOURCE_DIR is typically the cmake source directory +## BINARY_DIR is the build directory, typically 'build' + +function(download_folly SOURCE_DIR BINARY_DIR) + + + ExternalProject_Add( + facebook-folly-proj + GIT_REPOSITORY "https://github.com/facebook/folly.git"; + GIT_TAG "v2020.05.18.00" + SOURCE_DIR "${BINARY_DIR}/dependencies/facebook-folly-proj-src" + CMAKE_ARGS ${PASSTHROUGH_CMAKE_ARGS} Review comment: > My hope is to leverage an internal java project that runs a mini cluster and relies on maven to build a jar we can run for integration tests. This would be great. https://github.com/apache/hbase/tree/master/hbase-testing-util should have "enough" of what's needed to get going. Shout when you're ready for this and we can help. The hardest part will be explicitly listing all of the test scope dependencies, as maven won't naturally bring them in transitively (super fun -- test-scope deps have no transitive deps). > If we end up dockerizing this on ubuntu, we may run into this problem in which case we may have to install fmt dependency like other dependencies, just FYI. I think Docker is going to be a "requirement" for the rest of the HBase team to try to be "helpful". I'm not sure if there are any frameworks out there which would help us do the same setup+build+test across multiple OS's docker containers. That said, having just "one" platform which works is more than we have now :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
