Apache9 commented on a change in pull request #1753: URL: https://github.com/apache/hbase/pull/1753#discussion_r432215118
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/store/LocalStore.java ########## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.store; + +import java.io.IOException; +import java.util.concurrent.TimeUnit; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.Server; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.Get; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.regionserver.HRegion.FlushResult; +import org.apache.hadoop.hbase.regionserver.RegionScanner; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.yetus.audience.InterfaceAudience; + +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; + +/** + * Used for storing data at master side. The data will be stored in a {@link LocalRegion}. + */ [email protected] +public final class LocalStore { + + // Use the character $ to let the log cleaner know that this is not the normal wal file. + public static final String ARCHIVED_WAL_SUFFIX = "$masterlocalwal$"; + + public static final String ARCHIVED_HFILE_SUFFIX = "$masterlocalhfile$"; + + private static final String MAX_WALS_KEY = "hbase.master.store.region.maxwals"; + + private static final int DEFAULT_MAX_WALS = 10; + + public static final String USE_HSYNC_KEY = "hbase.master.store.region.wal.hsync"; + + public static final String MASTER_STORE_DIR = "MasterData"; + + private static final String FLUSH_SIZE_KEY = "hbase.master.store.region.flush.size"; + + private static final long DEFAULT_FLUSH_SIZE = TableDescriptorBuilder.DEFAULT_MEMSTORE_FLUSH_SIZE; + + private static final String FLUSH_PER_CHANGES_KEY = "hbase.master.store.region.flush.per.changes"; + + private static final long DEFAULT_FLUSH_PER_CHANGES = 1_000_000; + + private static final String FLUSH_INTERVAL_MS_KEY = "hbase.master.store.region.flush.interval.ms"; + + // default to flush every 15 minutes, for safety + private static final long DEFAULT_FLUSH_INTERVAL_MS = TimeUnit.MINUTES.toMillis(15); + + private static final String COMPACT_MIN_KEY = "hbase.master.store.region.compact.min"; + + private static final int DEFAULT_COMPACT_MIN = 4; + + private static final String ROLL_PERIOD_MS_KEY = "hbase.master.store.region.walroll.period.ms"; + + private static final long DEFAULT_ROLL_PERIOD_MS = TimeUnit.MINUTES.toMillis(15); + + private static final String RING_BUFFER_SLOT_COUNT = "hbase.master.store.ringbuffer.slot.count"; + + private static final int DEFAULT_RING_BUFFER_SLOT_COUNT = 128; + + public static final TableName TABLE_NAME = TableName.valueOf("master:store"); + + public static final byte[] PROC_FAMILY = Bytes.toBytes("proc"); + + private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE_NAME) + .setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build(); Review comment: Use their own column family. The problems of introduing more local regions are: 1. Each region would have its own fail recovery logic, which means we need to do lease recovery multiple times when starting master. 2. Maybe we need to duplicate all the configuations here multiple times for supporting different type of local regions, which is a pain for operators. 3. Maybe we need to introduce more types of HFileCleaner and WALCleaner, which is also a pain. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
