Apache9 commented on a change in pull request #1418:
URL: https://github.com/apache/hbase/pull/1418#discussion_r432432489
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -565,7 +565,7 @@ private boolean isCarryingRegion(final ServerName
serverName, final RegionInfo r
private RegionInfo getMetaForRegion(final RegionInfo regionInfo) {
Review comment:
This method should be removed?
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java
##########
@@ -302,6 +302,17 @@ public int compareTimestamps(final long ltimestamp, final
long rtimestamp) {
* {@link KeyValue}s.
*/
public static class RootCellComparator extends MetaCellComparator {
Review comment:
What is the difference between RootComparator and MetaComparator?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
##########
@@ -184,6 +184,12 @@ public static String prettyPrint(final String
encodedRegionName) {
public final static byte[] HIDDEN_END_KEY = RegionInfoDisplay.HIDDEN_END_KEY;
public final static byte[] HIDDEN_START_KEY =
RegionInfoDisplay.HIDDEN_START_KEY;
+ /** HRegionInfo for root region, we're using the new encoded format
+ * to try and reduce the amount of boilerplate code need to support the
legacy format */
+ public static final HRegionInfo ROOT_REGIONINFO =
Review comment:
The HRegionInfo has already been deprecated?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java
##########
@@ -495,5 +498,20 @@ public boolean equals(Object o) {
public int hashCode() {
return this.hashCode;
}
+
+ /**
+ * @return Comparator to use comparing {@link KeyValue}s.
+ * @deprecated Use Region#getCellComparator(). deprecated for hbase 2.0,
remove for hbase 3.0
+ */
+ @Deprecated
+ public KeyValue.KVComparator getComparator() {
Review comment:
What's this?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
##########
@@ -160,6 +161,8 @@ private static void checkRegionsToMerge(MasterProcedureEnv
env, final RegionInfo
* to have an extent sufficient to cover all regions-to-merge.
*/
private static RegionInfo createMergedRegionInfo(final RegionInfo[]
regionsToMerge) {
+ KeyValue.KVComparator comparator =
Review comment:
Why not use CellComparator?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java
##########
@@ -25,14 +25,9 @@
import java.util.List;
import java.util.Set;
import java.util.function.Supplier;
-import org.apache.hadoop.hbase.ConcurrentTableModificationException;
-import org.apache.hadoop.hbase.DoNotRetryIOException;
-import org.apache.hadoop.hbase.HBaseIOException;
-import org.apache.hadoop.hbase.HConstants;
-import org.apache.hadoop.hbase.MetaTableAccessor;
-import org.apache.hadoop.hbase.TableName;
-import org.apache.hadoop.hbase.TableNotDisabledException;
-import org.apache.hadoop.hbase.TableNotFoundException;
+
+import org.apache.hadoop.hbase.*;
Review comment:
Avoid start imports?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureUtil.java
##########
@@ -187,7 +187,13 @@ public static int getTablePriority(TableName tableName) {
* server carrying meta, and 1 for others.
*/
public static int getServerPriority(ServerProcedureInterface proc) {
Review comment:
The above getTablePriority should also be changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
