songxincun commented on a change in pull request #1801:
URL: https://github.com/apache/hbase/pull/1801#discussion_r432919519
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -379,6 +379,9 @@ private MemStore getMemstore() {
protected void createCacheConf(final ColumnFamilyDescriptor family) {
this.cacheConf = new CacheConfig(conf, family, region.getBlockCache(),
region.getRegionServicesForStores().getByteBuffAllocator());
+ LOG.info("Created cacheConfig: " + this.getCacheConfig()
Review comment:
> Looks good. There is another jira where we discuss abt changing
HStore#toString() to add region info also there. Then u will need to change
this also.
But, HStore#toString() prints only short name of column family without any
attribute. I am not sure is it suitable to use here. @anoopsjohn Would you
give me some suggestions? Thanks a lot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
