virajjasani commented on a change in pull request #1818:
URL: https://github.com/apache/hbase/pull/1818#discussion_r433237718
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -42,13 +43,18 @@
public CustomizedScanInfoBuilder(ScanInfo scanInfo) {
this.scanInfo = scanInfo;
- this.scan = new Scan();
+ try {
+ this.scan = new ImmutableScan(new Scan());
Review comment:
I just provided 2 constructors to ImmutableScan i.e.
1) Scan(Scan scan)
2) Scan(Get get)
I believe, given that this is Immutable subclass, providing default
constructor might not be much useful. Even if we give, it will internally use
`this(new Scan())`. Hence, I thought of not providing default constructor at
all. Thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
