infraio commented on a change in pull request #1823:
URL: https://github.com/apache/hbase/pull/1823#discussion_r433743253
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java
##########
@@ -102,8 +170,8 @@ public int getMultiple(long start, int len, byte[]
dstArray, int dstOffset) {
private final static Visitor GET_MULTIPLE_VISTOR = new Visitor() {
@Override
- public void visit(ByteBuffer bb, byte[] array, int arrayIdx, int len) {
- bb.get(array, arrayIdx, len);
+ public void visit(ByteBuffer bb, int pos, byte[] array, int arrayIdx, int
len) {
+ ByteBufferUtils.copyFromBufferToArray(array, bb, pos, arrayIdx, len);
Review comment:
Why change this? Seems this not belong to HBASE-17738?
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java
##########
@@ -142,11 +210,12 @@ public void visit(ByteBuffer bb, byte[] array, int
arrayIdx, int len) {
* bytes from the buffer to the destination array, else if it is a write
* action, we will transfer the bytes from the source array to the buffer
* @param bb byte buffer
+ * @param pos Start position in ByteBuffer
* @param array a source or destination byte array
* @param arrayOffset offset of the byte array
* @param len read/write length
*/
- void visit(ByteBuffer bb, byte[] array, int arrayOffset, int len);
+ void visit(ByteBuffer bb, int pos, byte[] array, int arrayOffset, int len);
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
