[
https://issues.apache.org/jira/browse/HBASE-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261751#comment-13261751
]
rajeshbabu commented on HBASE-5840:
-----------------------------------
@Stack
Thanks for your review.
bq.Do you have to convert the Exception to an IOE? WHy is that? What does this
method let out? IOEs only? If so, why we catch Exception? In case its a
non-checked exception?
Refactored the code in such a way setting status to abort without handling any
exceptions from initialize.
bq. it looks good too but in the finally you might want to use the new
HRegion.closeHRegion(region) to clean up the wal log
{code}
region = HRegion.newHRegion(path, null, fs, conf, info, htd, null);
{code}
As am passing null for WAL the close region does not try to do any operation
related to wal closing. But i have added it as per your suggestion as it does
no harm.
> Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing
> the old status
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-5840
> URL: https://issues.apache.org/jira/browse/HBASE-5840
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Gopinathan A
> Assignee: rajeshbabu
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5840.patch, HBASE-5840_v2.patch
>
>
> TaskMonitor Status will not be cleared in case Regions FAILED_OPEN. This will
> keeps showing old status.
> This will miss leads the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
