sguggilam commented on a change in pull request #1828:
URL: https://github.com/apache/hbase/pull/1828#discussion_r434041771
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java
##########
@@ -223,6 +226,41 @@ public void testReportForDutyWithMasterChange() throws
Exception {
}
+ /**
+ * Tests region sever reportForDuty with manual environment edge
+ */
+ @Test(timeout = 60000)
Review comment:
@virajjasani Makes sense, I will remove the timeout
I have seen TestClockSkewDetection, the tests basically mocks a server and
just tests the registration between RS and master. The current test in
TestRegionServerReportForDuty also checks if the master comes online and
finishes the initialization without any issue when a manual edge is inserted
which is where i could see the gap in RSProcedureDispatcher and made the
change. Please let me know if you think otherwise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
