[
https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125956#comment-17125956
]
Wellington Chevreuil commented on HBASE-23313:
----------------------------------------------
{quote}For me, I do not think it is a good idea to use a full RegionState as
parameter. On the HBCK2 command line, we only pass a region state and an
encoded region name, so here, I suggest we introduce a new datastructure, which
only has a encoded name and a state, and use it as the parameter.
{quote}
No big concerns. The reason for having made it that way was that I thought it
would be simpler for code maintenance to reuse existing messages. Agree the
request would carry two additional fields not needed for the sake of that
operation, but didn't think performance impact would be relevant to justify yet
another message to be defined.
> [hbck2] setRegionState should update Master in-memory state too
> ---------------------------------------------------------------
>
> Key: HBASE-23313
> URL: https://issues.apache.org/jira/browse/HBASE-23313
> Project: HBase
> Issue Type: Bug
> Components: hbck2
> Affects Versions: 2.1.7, 2.2.2
> Reporter: Michael Stack
> Assignee: Wellington Chevreuil
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> setRegionState changes the hbase:meta table info:state column. It does not
> alter the Master's in-memory state. This means you have to kill Master and
> have another assume Active Master role of a state-change to be noticed.
> Better if the setRegionState just went via Master and updated Master and
> hbase:meta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
