rvaleti commented on pull request #1857: URL: https://github.com/apache/hbase/pull/1857#issuecomment-639497608
> Looks good overall. Does it make sense to also add a small test to cover the configuration? @HorizonNet , I do not see any existing UTs for BlockingRpcConnection. The change is to do a lookup from Conf and fall back to default. This is a standard lookup pattern and must have already been covered at various test cases. I think it would be an overkill to add a new test class for just one config lookup test. Please let me know if you strongly insist. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
