Apache9 commented on a change in pull request #1858:
URL: https://github.com/apache/hbase/pull/1858#discussion_r436244996
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -146,45 +163,43 @@ private void established(Channel ch) throws IOException {
private boolean reloginInProgress;
private void scheduleRelogin(Throwable error) {
+ assert eventLoop.inEventLoop();
Review comment:
My intention is to let later developpers know that this method must be
called in the event loop thread. Do not want to introduce any overhead when
executing the code in production, as in production, if it is not called in an
event loop thread, it will be a ctitical bug and can not be recovered, so I do
not think it worth other checks like Preconditions.checkXXX...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
