[
https://issues.apache.org/jira/browse/HBASE-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127558#comment-17127558
]
Viraj Jasani edited comment on HBASE-24446 at 6/7/20, 9:30 AM:
---------------------------------------------------------------
I have reverted the applied commit from branch-1 (before more commits land on
branch-1):
[https://github.com/apache/hbase/commit/94a04fb88ca2fd68b68c37698323937a54c794d3].
Let's do one thing: First we can commit HBASE-24511 to all branches, close it
and then we can work on current Jira and commit it to all branches. Sounds good?
Although branch-1 patch was clean, without clear commit order, we have to
explicitly remember/maintain the commit order and that's a burden. (revert of
branch-1 patch is anyways temporary)
After getting one more +1 on HBASE-24511, the patch should be ready for commit.
Then we can come back on the current Jira :)
was (Author: vjasani):
I have reverted the applied commit from branch-1 (before more commits land on
branch-1). Let's do one thing: First we can commit HBASE-24511 to all branches,
close it and then we can work on current Jira and commit it to all branches.
Sounds good?
Although branch-1 patch was clean, without clear commit order, we have to
explicitly remember/maintain the commit order and that's a burden. (revert of
branch-1 patch is anyways temporary)
After getting one more +1 on HBASE-24511, the patch should be ready for commit.
Then we can come back on current Jira :)
> Use EnvironmentEdgeManager to compute clock skew in Master
> ----------------------------------------------------------
>
> Key: HBASE-24446
> URL: https://issues.apache.org/jira/browse/HBASE-24446
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Sandeep Guggilam
> Assignee: Sandeep Guggilam
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> There are few cases where the Master is not able to complete the
> initialization as it waiting for the region server to report to it. The
> region server actually reported to the master but the master rejected the
> request because of clock skew issue though both of them are on same JVM
> The Region server uses EnvironmentEdgeManager.currentTime to report the
> current time and HMaster uses System.currentTimeMillis() to get the current
> time for computation against the reported time by RS. We should also just
> use EnvironmentEdgeManager even in Master as we are expected not to use
> System.currentTime directly and instead go through EnvironmentEdgeManager
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
