Apache9 commented on pull request #1858: URL: https://github.com/apache/hbase/pull/1858#issuecomment-640229473
> Can we make sure we have a test that asserts are enabled that will also run when we run whatever tests we expect to exercise this code path to catch an assert failure should someone change the code such that these things run outside of the event loop? > > Something simple like a test that expects the exception from an assertion failure implemented with an assert that always fails? Done. Please see TestNettyRpcConnection. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
