bsglz commented on a change in pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#discussion_r436484665
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2457,8 +2463,13 @@ public FlushResultImpl flushcache(boolean
forceFlushAllStores, boolean writeFlus
}
try {
- Collection<HStore> specificStoresToFlush =
+ Collection<HStore> specificStoresToFlush = null;
+ if (!forceFlushAllStores && families != null) {
+ specificStoresToFlush = flushPolicy.selectStoresToFlush(stores,
families);
Review comment:
> Why do we pass in stores into selectStoresToFlush? We do not need the
list of stores in the flushAllStoresPolicy. It has access to 'this' so can
figure what Stores are in the Region.
As comment below, maybe it should not be part of flushPolicy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
