pustota2009 commented on a change in pull request #1257:
URL: https://github.com/apache/hbase/pull/1257#discussion_r436531476
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
##########
@@ -947,7 +1019,47 @@ public void run() {
}
LruBlockCache cache = this.cache.get();
if (cache == null) break;
- cache.evict();
+ bytesFreed = cache.evict();
+ long stopTime = System.currentTimeMillis();
+ // If heavy cleaning BlockCache control.
+ // It helps avoid put too many blocks into BlockCache
+ // when evict() works very active.
+ if (stopTime - startTime <= 1000 * 10 - 1) {
+ mbFreedSum += bytesFreed/1024/1024;
+ } else {
+ freedDataOverheadPercent =
Review comment:
I thought it is better shows which overhead we have. When we use -100 it
looks clearly for me because can show values below zero. But it is possible
to change, if you think of this better for understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
