[
https://issues.apache.org/jira/browse/HBASE-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262329#comment-13262329
]
jirapos...@reviews.apache.org commented on HBASE-5712:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4883/#review7248
-----------------------------------------------------------
Looks very good.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4883/#comment16018>
This is ok. However, I think it is better to use a timed wait in case it
hangs.
- Jimmy
On 2012-04-26 01:42:01, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4883/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 01:42:01)
bq.
bq.
bq. Review request for hbase, Ted Yu and Jimmy Xiang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. * Parallelized load of .regioninfo files
bq. * changed TreeMap to SortedMap in method signatures
bq. * renamed a test's name.
bq.
bq.
bq. This addresses bug HBASE-5712.
bq. https://issues.apache.org/jira/browse/HBASE-5712
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10
bq.
bq. Diff: https://reviews.apache.org/r/4883/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran patch 10x on trunk, passes. Ran 1x on 0.92 and 0.94.
bq.
bq. Ther 0.90 version that is nearly identical except for ignoring changes
near lines HBaseFsck lines 671-680.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Parallelize load of .regioninfo files in diagnostic/repair portion of hbck.
> ---------------------------------------------------------------------------
>
> Key: HBASE-5712
> URL: https://issues.apache.org/jira/browse/HBASE-5712
> Project: HBase
> Issue Type: Sub-task
> Components: hbck
> Affects Versions: 0.90.7, 0.92.2, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-5712-90.patch, hbase-5712.patch
>
>
> On heavily loaded hdfs's some dfs nodes may not respond quickly and backs off
> for 60s before attempting to read data from another datanode. Portions of
> the information gathered from hdfs (.regioninfo files) are loaded serially.
> With HBase with clusters with 100's, or 1000's, or 10000's regions
> encountering these 60s delay blocks progress and can be very painful.
> There is already some parallelization of portions of the hdfs information
> load operations and the goal here is move the reading of .regioninfos into
> the parallelized sections..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
