saintstack commented on a change in pull request #1862:
URL: https://github.com/apache/hbase/pull/1862#discussion_r437496770
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -173,6 +176,12 @@ if [ -n "$JAVA" ]; then
JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
fi
+MAVEN_MOUNT=()
+if [ -n "${MAVEN_VOLUME}" ]; then
+ MAVEN_MOUNT=(--mount
"type=volume,src=${MAVEN_VOLUME},dst=/home/hbase-rm/.m2-repository/")
+ echo "REPO=/home/hbase-rm/.m2-repository" >> "${ENVFILE}"
Review comment:
s/hbase-rm/${USER}/ ?
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -173,6 +176,12 @@ if [ -n "$JAVA" ]; then
JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
fi
+MAVEN_MOUNT=()
+if [ -n "${MAVEN_VOLUME}" ]; then
+ MAVEN_MOUNT=(--mount
"type=volume,src=${MAVEN_VOLUME},dst=/home/hbase-rm/.m2-repository/")
+ echo "REPO=/home/hbase-rm/.m2-repository" >> "${ENVFILE}"
Review comment:
Or, the whole point is a clean dir into which the build can populate a
new .m2 repository or is it that you want to point the build at an existing
populated local repo?
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -173,6 +176,12 @@ if [ -n "$JAVA" ]; then
JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
fi
+MAVEN_MOUNT=()
+if [ -n "${MAVEN_VOLUME}" ]; then
+ MAVEN_MOUNT=(--mount
"type=volume,src=${MAVEN_VOLUME},dst=/home/hbase-rm/.m2-repository/")
+ echo "REPO=/home/hbase-rm/.m2-repository" >> "${ENVFILE}"
Review comment:
oh. this is in the container? And hbase-rm is a container user? You are
trying to share the repo across build stages? ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
