bharathv commented on a change in pull request #1879:
URL: https://github.com/apache/hbase/pull/1879#discussion_r437747899
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
##########
@@ -66,8 +66,14 @@ public HACK_UNTIL_ZOOKEEPER_1897_ZooKeeperMain(String[] args)
* @throws IOException
* @throws InterruptedException
*/
- void runCmdLine() throws KeeperException, IOException,
InterruptedException {
- processCmd(this.cl);
+ void runCmdLine() throws IOException, InterruptedException {
+ try {
+ processCmd(this.cl);
+ } catch (IOException | InterruptedException e) {
+ throw e;
+ } catch (Exception e) {
Review comment:
> ZK 3.6 throws another type of checked exception, which causes a
compilation error
I didn't see it here [1], hence my question. May be I missed something.
[1]
https://github.com/apache/zookeeper/blob/branch-3.6/zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java#L380
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
##########
@@ -85,14 +85,20 @@ public static void main(String[] args) {
}
private static void runZKServer(QuorumPeerConfig zkConfig) throws
UnknownHostException, IOException {
Review comment:
Ah, okay. I missed the AdminServerException exception from the
signature, wfm to keep it as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
