[
https://issues.apache.org/jira/browse/HBASE-24340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129932#comment-17129932
]
Hudson commented on HBASE-24340:
--------------------------------
Results for branch branch-2
[build #2699 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2699/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2699/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2699/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2699/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2699/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> PerformanceEvaluation options should not mandate any specific order
> -------------------------------------------------------------------
>
> Key: HBASE-24340
> URL: https://issues.apache.org/jira/browse/HBASE-24340
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Anoop Sam John
> Assignee: Sambit Mohapatra
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> During parsing of options, there are some validations. One such is checking
> whether autoFlush = false AND multiPut > 0. This validation code mandates an
> order that autoFlush=true should be specified before adding multiPut = x in
> PE command.
> {code}
> final String multiPut = "--multiPut=";
> if (cmd.startsWith(multiPut)) {
> opts.multiPut = Integer.parseInt(cmd.substring(multiPut.length()));
> if (!opts.autoFlush && opts.multiPut > 0) {
> throw new IllegalArgumentException("autoFlush must be true when
> multiPut is more than 0");
> }
> continue;
> }
> {code}
> 'autoFlush ' default value is false. If multiPut is specified prior to
> autoFlush in the PE command, we will end up throwing IllegalArgumentException.
> Checking other validations, seems not having such issue. Still better to
> move all the validations together into a private method and call that once
> the parse is over.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
