saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-641736719
Hopefully we can do work up front that makes it so new clients do not have to take a big pause while downloading MBs joining a big cluster. `There is no paging support in the client facing API right?` We do have 'paging' in client API; Scans (I talked of paging/iterating/cursor/scan-like API, I thought?). Here I'm advocating reuse and existing models -- e.g. RegionLocator Interface seems to have your two APIs already as you note so why wouldn't we use it instead in ConnectionRegistry? --rather than new API and new PBs. The response seems to be that its all internal so its going to be fine; sure we can make it work but if an opportunity for reuse, it could be better. We can add prefetch to the PB to 'improve' performance but the API is still one-at-a-time; consumer has to do the juggling to figure what it should pass in as the next 'row'; instead of just next'ing to get next Region. I get your bit about Scan being too much to expose. That seems good. But the model of iterating across Table results I think we should keep here; doesn't have to be full-on Scan. Master doesn't expose Scan Interface so I suppose we can't reuse Scan RPC. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
