phrocker commented on a change in pull request #3:
URL: https://github.com/apache/hbase-native-client/pull/3#discussion_r438102207
##########
File path: CMakeLists.txt
##########
@@ -25,15 +25,119 @@ set(PROJECT_VERSION_PATCH 0)
set(BUILD_SHARED_LIBS ON)
## set our cmake module path
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
+include(CMakeDependentOption)
+include(CheckIncludeFile)
+include(ExternalProject)
+include(DownloadProject)
+include(ExecuteMaven)
+include(CheckCXXCompilerFlag)
+
+
+option(DOWNLOAD_DEPENDENCIES "Downloads and builds all dependencies locally "
OFF)
+option(HBASE_TARGET_TAG "HBase tag to be used if HBASE_HOME is not set"
"e5345b3a7c32c6a80394319c17540b84c8fe66ba")
Review comment:
Created https://issues.apache.org/jira/browse/HBASE-24531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
