[ 
https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133149#comment-17133149
 ] 

Hudson commented on HBASE-24184:
--------------------------------

Results for branch branch-1
        [build #1313 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1313/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1313//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1313//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1313//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Backport HBASE-23896 to branch-1: Snapshot owner cannot delete snapshot when 
> ACL is enabled and Kerberos is not enabled
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-24184
>                 URL: https://issues.apache.org/jira/browse/HBASE-24184
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>            Reporter: tianhang tang
>            Assignee: tianhang tang
>            Priority: Minor
>             Fix For: 1.7.0
>
>
> For the owner of snapshots(not global admin user), currently list_snapshots 
> returns empty if i just use simple acls for authorization but not use 
> authentication.
> The code in AccessController.preListSnapshot:
> {code:java}
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
> // list it, if user is the owner of snapshot
> AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
> "Snapshot owner check allowed", user, null, null, null);
> accessChecker.logResult(result);
> }{code}
> And SnapshotManager.takeSnapshotInternal:
> {code:java}
> if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
>   builder.setOwner(user.getShortName());
> }
> {code}
> User.isHBaseSecurityEnabled:
> {code:java}
> public static boolean isHBaseSecurityEnabled(Configuration conf) {
>   return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
> }
> {code}
> So i think the logic of setOwner is used for authorization, not 
> authentication, SnapshotManager should not only setOwner when 
> hbase.security.authentication = kerberos, which cause listSnapshots returns 
> empty when i just use simple acls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to