anoopsjohn commented on a change in pull request #1881:
URL: https://github.com/apache/hbase/pull/1881#discussion_r439193707
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -2741,7 +2741,8 @@ private void removeCompactedfiles(Collection<HStoreFile>
compactedfiles)
LOG.trace("Closing and archiving the file {}", file);
// Copy the file size before closing the reader
final long length = r.length();
- r.close(true);
+ r.close(file.getCacheConf() != null ?
Review comment:
Sorry I was not clear in above comment. My ask was this.
This is called from closeAndArchiveCompactedFiles() and HStore#close().
The former is called in an async way by the Discharger thread anyways. When
this area is called by that flow, we can preserve what is there today (Passing
true). Close time ya lets honor the config. Sounds ok?
Ideally speaking we should have handled whole these in another way. Within
the Cache implementation, the evict by hfile would have been an async impl. So
the caller wont get blocked. But ya lets handle that in another jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
