[ 
https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133734#comment-17133734
 ] 

Andrew Kyle Purtell edited comment on HBASE-24528 at 6/12/20, 5:59 PM:
-----------------------------------------------------------------------

If we are going to discuss this let’s not use exaggeration. Nobody is 
suggesting “everywhere”. Right now there are two proposals and we are looking 
at factoring and DRY which are widely recognized good things to attempt in 
design. One use case isn’t even implemented yet. Alternative proposals are 
welcome but “use a local region” is insufficiently detailed compared to the 
alternative. 

For example:
 - For the slow log case, can we have a local region per regionserver. How is 
region growth, splits, and assignments managed in that case to ensure locality?
 - For the balancer log case, I understand we can have the master host regions 
so that’s good but the same concerns around region management apply too.

If local regions turn out to be a good answer, great, let’s do it, but the ring 
buffer w hdfs write behind persistence option does not have the same potential 
complications. Instead, it has others, to be fair. And on the plus side for 
region/table storage, its already row structured and buffered (memstore) and 
has write behind persistence (flushing) so certainly could be advantageous.

Also, we want to include this in branch-1, so what are the chances of porting 
back local regions there to support this? Have they even landed in branch-2? 
Again I’m not arguing against them just pointing out how they don’t seem an 
automatic win. 

Edit: Consolidated two comments into one.


was (Author: apurtell):
For example:
 - For the slow log case, can we have a local region per regionserver. How is 
region growth, splits, and assignments managed in that case to ensure locality?
 - For the balancer log case, I understand we can have the master host regions 
so that’s good but the same concerns around region management apply too.

If local regions turn out to be a good answer, great, let’s do it, but the ring 
buffer w hdfs write behind persistence option does not have the same potential 
complications. Instead, it has others, to be fair. And on the plus side for 
region/table storage, its already row structured and buffered (memstore) and 
has write behind persistence (flushing) so certainly could be advantageous.

Also, we want to include this in branch-1, so what are the chances of porting 
back local regions there to support this? Have they even landed in branch-2? 
Again I’m not arguing against them just pointing out how they don’t seem an 
automatic win. 

> Improve balancer decision observability
> ---------------------------------------
>
>                 Key: HBASE-24528
>                 URL: https://issues.apache.org/jira/browse/HBASE-24528
>             Project: HBase
>          Issue Type: New Feature
>          Components: Admin, Balancer, Operability, shell, UI
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>
> We provide detailed INFO and DEBUG level logging of balancer decision 
> factors, outcome, and reassignment planning, as well as similarly detailed 
> logging of the resulting assignment manager activity. However, an operator 
> may need to perform online and interactive observation, debugging, or 
> performance analysis of current balancer activity. Scraping and correlating 
> the many log lines resulting from a balancer execution is labor intensive and 
> has a lot of latency (order of ~minutes to acquire and index, order of 
> ~minutes to correlate). 
> The balancer should maintain a rolling window of history, e.g. the last 100 
> region move plans, or last 1000 region move plans submitted to the assignment 
> manager. This history should include decision factor details and weights and 
> costs. The rsgroups balancer may be able to provide fairly simple decision 
> factors, like for example "this table was reassigned to that regionserver 
> group". The underlying or vanilla stochastic balancer on the other hand, 
> after a walk over random assignment plans, will have considered a number of 
> cost functions with various inputs (locality, load, etc.) and multipliers, 
> including custom cost functions. We can devise an extensible class structure 
> that represents explanations for balancer decisions, and for each region move 
> plan that is actually submitted to the assignment manager, we can keep the 
> explanations of all relevant decision factors alongside the other details of 
> the assignment plan like the region name, and the source and destination 
> regionservers. 
> This history should be available via API for use by new shell commands and 
> admin UI widgets.
> The new shell commands and UI widgets can unpack the representation of 
> balancer decision components into human readable output. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to