anoopsjohn commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r439611166
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java
##########
@@ -41,39 +40,42 @@
private final HRegionServer regionServer;
private ScheduledExecutorService executor;
private Runnable runnable;
- private long period;
+ private static final int PERIOD = 45;
private ScheduledFuture<?> tableMetricsUpdateTask;
private ConcurrentHashMap<TableName, MetricsTableValues> metricsTableMap
= new ConcurrentHashMap<>();
public MetricsTableWrapperAggregateImpl(final HRegionServer regionServer) {
this.regionServer = regionServer;
- this.period =
regionServer.getConfiguration().getLong(HConstants.REGIONSERVER_METRICS_PERIOD,
- HConstants.DEFAULT_REGIONSERVER_METRICS_PERIOD) + 1000;
this.executor =
CompatibilitySingletonFactory.getInstance(MetricsExecutor.class).getExecutor();
this.runnable = new TableMetricsWrapperRunnable();
- this.tableMetricsUpdateTask =
this.executor.scheduleWithFixedDelay(this.runnable, period,
- this.period, TimeUnit.MILLISECONDS);
+ this.tableMetricsUpdateTask =
this.executor.scheduleWithFixedDelay(this.runnable, PERIOD,
Review comment:
I would request to keep this out of this PR. Raise another specific
Jira to address this issue and may be below one also and get it committed as
part of that. Later it will be easy for some one who is searching the change
history/ bug fix history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
