virajjasani commented on a change in pull request #1869:
URL: https://github.com/apache/hbase/pull/1869#discussion_r440199005
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1285,7 +1285,9 @@ private boolean waitForNamespaceOnline() throws
InterruptedException, IOExceptio
}
// Else there are namespace regions up in meta. Ensure they are assigned
before we go on.
for (RegionInfo ri : ris) {
- isRegionOnline(ri);
+ if (!isRegionOnline(ri)) {
Review comment:
@ramkrish86 from this code block, we just return false and we return
back from `finishActiveMasterInitialization()` without any further
initialization because mostly this will happen when HM server is going down so
we expect `finishActiveMasterInitialization()` to return instead of going
further with any further init:
`finishActiveMasterInitialization()`:
```
if (!waitForNamespaceOnline()) {
return;
}
```
`waitForNamespaceOnline()`:
```
if (!isRegionOnline(ri)) {
return false;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
