Wellington Chevreuil created HBASE-24571:
--------------------------------------------
Summary: HBCK2 fix addFsRegionsMissingInMeta to add regions in
CLOSED state again
Key: HBASE-24571
URL: https://issues.apache.org/jira/browse/HBASE-24571
Project: HBase
Issue Type: Bug
Components: hbase-operator-tools
Reporter: Wellington Chevreuil
Assignee: Wellington Chevreuil
Originally, _addFsRegionsMissingInMeta_ relied on _MetaTableAccessor_ to add
new regions, which correctly added new regions in CLOSED state. HBASE-23791
removed dependency on _MetaTableAccessor_ as to avoid relying on HBase IA
private methods. _MetaTableAccessor_ functions needed by HBCK2 were then
re-implemented on _HBCKMetaTableAccessor_. Implementation for
_addRegionToMeta_, though, was not fully ported, and it was not setting newly
added regions state.
This would cause attempts to assign the newly added regions to fail, as AM
ignore regions without state defined in meta, requiring extra calls for hbck2
setRegionState command for each of the newly added regions.
Kudos for [~brfrn169] who identified this problem while troubleshooting/fixing
regions assignments issues with hbck2.
This PR fix implementation of _HBCKMetaTableAccessor_._addRegionToMeta_ to
insert new regions with _CLOSED_ state, and also adds extra checks for this
behaviour on both _TestHBCKMetaTableAccessor_ and _TestFsRegionsMetaRecoverer_
UTs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
