virajjasani commented on a change in pull request #1921:
URL: https://github.com/apache/hbase/pull/1921#discussion_r441756545
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
##########
@@ -148,6 +148,16 @@ public boolean saslConnect(InputStream inS, OutputStream
outS) throws IOExceptio
inStream.readFully(saslToken);
}
}
+
+ try {
+ readStatus(inStream);
+ }
+ catch (IOException e){
+ if(e instanceof RemoteException){
Review comment:
I think you removed the outer condition instead of `if(e instanceof
RemoteException)`. Let me copy my previous comment:
I know `RemoteException` coming from `readStatus` is imp to us but we don't
want to swallow IOException if `inStream.readInt()` throws one because
`inStream.readInt()` is pre-requisite to know whether the status is
`SaslStatus.SUCCESS`
I am talking about what is happening within `readStatus(inStream)` call.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
##########
@@ -148,6 +148,16 @@ public boolean saslConnect(InputStream inS, OutputStream
outS) throws IOExceptio
inStream.readFully(saslToken);
}
}
+
+ try {
+ readStatus(inStream);
+ }
+ catch (IOException e){
+ if(e instanceof RemoteException){
Review comment:
I think you removed the outer condition instead of
`if(e instanceof RemoteException)`.
Let me copy my previous comment:
I know `RemoteException` coming from `readStatus` is imp to us but we don't
want to swallow IOException if `inStream.readInt()` throws one because
`inStream.readInt()` is pre-requisite to know whether the status is
`SaslStatus.SUCCESS`
I am talking about what is happening within `readStatus(inStream)` call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
